Skip to content

Comments

[WIP/DNM] crux extraction is optional from UI#130

Closed
staceysv wants to merge 4 commits intomainfrom
crux_optional
Closed

[WIP/DNM] crux extraction is optional from UI#130
staceysv wants to merge 4 commits intomainfrom
crux_optional

Conversation

@staceysv
Copy link
Contributor

1. What is the goal of this PR?

  • make the crux extraction step optional
  • match crux prompting logic to other pipeline steps (so users can see & override the prompt)

2. What specific parts of T3C are you changing and how?

  • moved crux logic to match other prompt instructions
  • tried to add a checkbox — ideally we'd check the value of this checkbox and only run the crux extraction step if a user actively checked that box

3. How did you test these changes?

  • working so far on localhost
  • need to figure out how to correctly set the default value to false and pass it through to workers.ts if the user checks the box

@Brandon-Perry
Copy link
Contributor

I think it would be good practice to set this as a draft PR if it's not ready for merging.

@staceysv staceysv marked this pull request as draft March 21, 2025 17:26
@staceysv
Copy link
Contributor Author

I think it would be good practice to set this as a draft PR if it's not ready for merging.

@Brandon-Perry thanks good reminder, thought I did!

@Brandon-Perry
Copy link
Contributor

@staceysv also I notice there's a a bunch of linting commits. Try running npm run format at the root level before adding and committing. If you forget, you can add again and run git commit --amend --no-edit if you haven't pushed, and it'll retroactively add those changes.

@staceysv staceysv closed this Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants